pre-commit: Add DCO check#959
Merged
Merged
Conversation
Signed-off-by: Philipp Jungkamp <philipp.jungkamp@rwth-aachen.de>
54a0481 to
8967dc5
Compare
stv0g
approved these changes
Sep 8, 2025
Member
|
This is not a check, but it adds the sign-off automatically, right? Why don't you use |
Contributor
|
I believe there are many pre-commit checks which are "auto-fixing" the code. This would be one of them. Contributors could still use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found myself force-pushing some commits in every PR I've made, just to reword and signoff on all commits. I wrote a little prepare-commit-msg hook that appends the DCO to every commit message automatically.
You can install this hook using: